-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Idle Account Suspension API to return disabled and non-disabled users #901
base: master
Are you sure you want to change the base?
Improve Idle Account Suspension API to return disabled and non-disabled users #901
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
============================================
+ Coverage 50.91% 51.14% +0.23%
- Complexity 2431 2445 +14
============================================
Files 298 300 +2
Lines 17979 18049 +70
Branches 2585 2591 +6
============================================
+ Hits 9154 9232 +78
+ Misses 7673 7663 -10
- Partials 1152 1154 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e35c0e1
to
b7bf193
Compare
b7bf193
to
caa1213
Compare
trigger a PR builder before merging it |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12686165198
Purpose
This PR enhance the getInactiveUsers API to:
Implementation
Implementation uses a boolean variable to decide on whether to include disabled users or exclude disabled users. This uses a nested query to get all the inactive users for a given time period and filters disabled or non-disabled users.
Example
Sample Request
https://localhost:9443/api/idle-account-identification/v1/inactive-users?inactiveAfter=2024-12-21&excludeBefore=2024-12-11&filter=isDisabled eq false
Sample Response
Related Issue